MLE-23439 - Change the TLS settings to "TLS" to permit the JVM to choose the highest possible. #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ose the highest possible. Also, fixes a Polaris issue regarding the TransformerFactory.
BillFarber
requested review from
anu3990,
Copilot,
rjrudin and
stevebio
and removed request for
anu3990,
rjrudin and
stevebio
There was a problem hiding this comment.
Pull Request Overview
This PR changes the default TLS version configuration from "TLSv1.2" to "TLS" to allow the JVM to automatically select the highest available TLS version, and adds security improvements to the TransformerFactory to prevent XML External Entity (XXE) injection vulnerabilities.
- Updated TLS version default from "TLSv1.2" to "TLS" across configuration files and tests
- Enhanced TransformerFactory security by implementing XXE prevention measures
- Updated documentation to reflect the new TLS configuration behavior
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/marklogic/kafka/connect/MarkLogicConfig.java | Changed default TLS version from "TLSv1.2" to "TLS" |
| src/main/java/com/marklogic/kafka/connect/DefaultDatabaseClientConfigBuilder.java | Updated simple SSL configuration to use "TLS" protocol |
| src/main/java/com/marklogic/kafka/connect/source/XmlPlanInvoker.java | Added secure TransformerFactory configuration with XXE prevention |
| src/test/java/com/marklogic/kafka/connect/BuildDatabaseClientConfigTest.java | Updated test cases to use "TLS" instead of "TLSv1.2" |
| docs/configuring-the-connector.md | Updated documentation to reflect new TLS default behavior |
| config/marklogic-source.properties | Updated example configuration to use "TLS" |
| config/marklogic-sink.properties | Updated example configuration to use "TLS" |
rjrudin
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fixes a Polaris issue regarding the TransformerFactory.
This has been tested locally with the automated tests as well as manually.